Open
Conversation
vtavana
force-pushed
the
dask-interface
branch
from
8e78150 to
90578c9
Compare
vtavana
force-pushed
the
dask-interface
branch
from
90578c9 to
647d164
Compare
vtavana
requested review from
antonwolfy,
ndgrigorian and
xaleryb
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Dask interface for the mkl_fft package, providing a drop-in replacement for the dask.fft module that leverages Intel MKL's optimized FFT implementations.
- Implements
mkl_fft.interfaces.dask_fftmodule with all FFT functions wrapped using Dask'sfft_wrap - Adds comprehensive test suite for the new Dask interface functionality
- Updates build configuration and documentation to support the new interface
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Adds dask_interface optional dependency and includes dask in test dependencies |
| mkl_fft/interfaces/dask_fft.py | New module implementing Dask FFT interface by wrapping numpy_fft functions |
| mkl_fft/tests/third_party/dask/test_dask_fft.py | Comprehensive test suite for Dask FFT functionality |
| mkl_fft/tests/test_interfaces.py | Updates interface tests to include Dask FFT |
| mkl_fft/interfaces/init.py | Conditionally imports dask_fft module when Dask is available |
| mkl_fft/interfaces/README.md | Adds documentation for the new Dask interface |
| conda-recipe/meta.yaml | Updates conda recipe to include dask test dependency and import test |
| conda-recipe-cf/meta.yaml | Updates conda-forge recipe similarly |
| CHANGELOG.md | Documents the new Dask interface feature |
| .github/workflows/*.yml | Updates CI workflows to include dask as test dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jharlow-intel
requested changes
Nov 13, 2025
Contributor
jharlow-intel
left a comment
jharlow-intel
left a comment
There was a problem hiding this comment.
some conflicts need to be resolved.
It's okay that the 3.14 internal CI is broken for now, though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address #5